Skip to content

feat: cookie based consistent hashing#3683

Merged
arkodg merged 2 commits intoenvoyproxy:mainfrom
arkodg:cookie-hash-impl
Jul 4, 2024
Merged

feat: cookie based consistent hashing#3683
arkodg merged 2 commits intoenvoyproxy:mainfrom
arkodg:cookie-hash-impl

Conversation

@arkodg
Copy link
Copy Markdown
Contributor

@arkodg arkodg commented Jun 27, 2024

Fixes: #2624

@arkodg arkodg requested a review from a team as a code owner June 27, 2024 00:38
@arkodg arkodg marked this pull request as draft June 27, 2024 00:38
@arkodg arkodg added this to the v1.1.0-rc1 milestone Jun 27, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 27, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 10 lines in your changes missing coverage. Please review.

Project coverage is 68.99%. Comparing base (4602f6d) to head (1de8ca2).
Report is 7 commits behind head on main.

Files Patch % Lines
internal/xds/translator/route.go 44.44% 8 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3683      +/-   ##
==========================================
- Coverage   69.05%   68.99%   -0.07%     
==========================================
  Files         176      176              
  Lines       21688    21739      +51     
==========================================
+ Hits        14977    14998      +21     
- Misses       5632     5659      +27     
- Partials     1079     1082       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Arko Dasgupta added 2 commits July 2, 2024 21:50
Fixes: envoyproxy#2624

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@arkodg arkodg force-pushed the cookie-hash-impl branch from d44050a to 1de8ca2 Compare July 3, 2024 23:51
@arkodg arkodg marked this pull request as ready for review July 3, 2024 23:54
Copy link
Copy Markdown
Member

@zirain zirain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, need docs and tests.

@arkodg
Copy link
Copy Markdown
Contributor Author

arkodg commented Jul 4, 2024

LGTM, need docs and tests.

yeah added issues to track that, will pick those up and complete them by v1.1

@arkodg arkodg requested review from a team July 4, 2024 00:15
Copy link
Copy Markdown
Contributor

@shawnh2 shawnh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zirain
Copy link
Copy Markdown
Member

zirain commented Jul 4, 2024

/retest

@arkodg arkodg merged commit 9f8adfb into envoyproxy:main Jul 4, 2024
@arkodg arkodg deleted the cookie-hash-impl branch July 4, 2024 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support Cookie based Consistent Hashing / Session Affinity

3 participants