feat(translator): implement buffer limit support in CTP#3058
Merged
arkodg merged 5 commits intoenvoyproxy:mainfrom Apr 5, 2024
Merged
feat(translator): implement buffer limit support in CTP#3058arkodg merged 5 commits intoenvoyproxy:mainfrom
arkodg merged 5 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Yael Shechter <yael.shechter@sap.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3058 +/- ##
==========================================
+ Coverage 66.54% 66.56% +0.02%
==========================================
Files 157 157
Lines 21956 21971 +15
==========================================
+ Hits 14611 14626 +15
Misses 6502 6502
Partials 843 843 ☔ View full report in Codecov by Sentry. |
guydc
reviewed
Mar 29, 2024
| return fmt.Errorf("invalid BufferLimit value %s", connection.BufferLimit.String()) | ||
| } | ||
| if bufferLimit < 0 || bufferLimit > math.MaxUint32 { | ||
| return fmt.Errorf("BufferLimit value %d out of range", bufferLimit) |
Contributor
There was a problem hiding this comment.
Maybe use connection.BufferLimit.String() here as well? It makes the error a bit more clear to the end user, as that's the value that was provided before the translation to bytes.
Signed-off-by: Yael Shechter <yael.shechter@sap.com>
guydc
approved these changes
Apr 1, 2024
Contributor
Author
|
/retest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Implement buffer limit in ClientTrafficPolicy
Follow up of #2805
Fixes #2600