feat(translator): implement idle timeout in ClientTrafficPolicy#3056
feat(translator): implement idle timeout in ClientTrafficPolicy#3056guydc merged 8 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Yael Shechter <yael.shechter@sap.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3056 +/- ##
==========================================
+ Coverage 58.08% 58.09% +0.01%
==========================================
Files 165 165
Lines 27460 27477 +17
==========================================
+ Hits 15950 15964 +14
- Misses 10557 10560 +3
Partials 953 953 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Yael Shechter <yael.shechter@sap.com>
…into idle-timeout-impl
…envoy-gateway into idle-timeout-impl
internal/xds/translator/listener.go
Outdated
| mgr.RequestTimeout = durationpb.New(irListener.Timeout.HTTP.RequestReceivedTimeout.Duration) | ||
| } | ||
|
|
||
| if irListener.Timeout != nil && irListener.Timeout.HTTP != nil && irListener.Timeout.HTTP.IdleTimeout != nil { |
There was a problem hiding this comment.
is irListener.Timeout != nil && irListener.Timeout.HTTP != nil redundant here?
There was a problem hiding this comment.
indeed, removed thanks
|
|
||
| case httpIR.Timeout.HTTP == nil: | ||
| httpIR.Timeout.HTTP = &ir.HTTPClientTimeout{} | ||
| setHTTPTimeout(httpIR) |
There was a problem hiding this comment.
Can we initialize this IR container once if it's needed and avoid the init-if-nil call for each member?
There was a problem hiding this comment.
changed it a bit, without this function
Signed-off-by: Yael Shechter <yael.shechter@sap.com>
|
/retest |
zirain
left a comment
There was a problem hiding this comment.
LGTM, docs and e2e tests should be added with following PRs.
|
/retest |
What type of PR is this?
Implement idle timeout in ClientTrafficPolicy
Follow up of #3042
Fixes #2861