feat: add PolicyStatus for EnvoyPatchPolicy#2910
Merged
Xunzhuo merged 5 commits intoenvoyproxy:mainfrom Mar 14, 2024
Merged
Conversation
Signed-off-by: shawnh2 <shawnhxh@outlook.com>
Signed-off-by: shawnh2 <shawnhxh@outlook.com>
Signed-off-by: shawnh2 <shawnhxh@outlook.com>
shawnh2
commented
Mar 13, 2024
| `, | ||
| expect: true, | ||
| }, | ||
| // TODO(sh2): add a policy status test for egctl x status cmd |
Contributor
Author
There was a problem hiding this comment.
will update egctl x status as a follow-up
Contributor
Author
|
/retest |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2910 +/- ##
==========================================
+ Coverage 64.45% 64.52% +0.07%
==========================================
Files 122 122
Lines 21037 21092 +55
==========================================
+ Hits 13559 13610 +51
- Misses 6630 6634 +4
Partials 848 848 ☔ View full report in Codecov by Sentry. |
Member
|
/retest |
zhaohuabing
reviewed
Mar 14, 2024
internal/xds/translator/testdata/out/xds-ir/jsonpatch-missing-resource.envoypatchpolicies.yaml
Outdated
Show resolved
Hide resolved
zhaohuabing
reviewed
Mar 14, 2024
Member
zhaohuabing
left a comment
There was a problem hiding this comment.
This looks really great! Just a tiny nit.
Signed-off-by: shawnh2 <shawnhxh@outlook.com>
zirain
approved these changes
Mar 14, 2024
Xunzhuo
approved these changes
Mar 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #2631