feat(translator): add default retry budget and retry host predicate#2757
Merged
arkodg merged 1 commit intoenvoyproxy:mainfrom Mar 3, 2024
Merged
feat(translator): add default retry budget and retry host predicate#2757arkodg merged 1 commit intoenvoyproxy:mainfrom
arkodg merged 1 commit intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Guy Daich <guy.daich@sap.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2757 +/- ##
==========================================
+ Coverage 63.53% 63.56% +0.02%
==========================================
Files 123 123
Lines 20169 20185 +16
==========================================
+ Hits 12814 12830 +16
Misses 6533 6533
Partials 822 822 ☔ View full report in Codecov by Sentry. |
Member
|
/retest |
zirain
approved these changes
Mar 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR sets default values for:
These values are inspired by envoy and istio recommendations, and intended to improve the overall success of retries when the backend is going through a rolling restart.
Which issue(s) this PR fixes:
Fixes #2754