Skip to content

e2e: increase the size of header to avoid flaky#2743

Merged
zirain merged 2 commits intoenvoyproxy:mainfrom
zirain:timeout-e2e
Mar 2, 2024
Merged

e2e: increase the size of header to avoid flaky#2743
zirain merged 2 commits intoenvoyproxy:mainfrom
zirain:timeout-e2e

Conversation

@zirain
Copy link
Copy Markdown
Member

@zirain zirain commented Mar 1, 2024

Fixes: #2720

@zirain zirain requested a review from a team as a code owner March 1, 2024 09:50
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.53%. Comparing base (3e70498) to head (41d0092).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2743   +/-   ##
=======================================
  Coverage   63.53%   63.53%           
=======================================
  Files         123      123           
  Lines       20169    20169           
=======================================
  Hits        12814    12814           
  Misses       6533     6533           
  Partials      822      822           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zirain
Copy link
Copy Markdown
Member Author

zirain commented Mar 1, 2024

failed to set a small timeout, see #2744 for more info.

zirain added 2 commits March 2, 2024 12:40
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
@zirain zirain requested a review from arkodg March 2, 2024 04:43
Copy link
Copy Markdown
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

@zirain
Copy link
Copy Markdown
Member Author

zirain commented Mar 2, 2024

/retest

@arkodg arkodg requested review from a team March 2, 2024 05:04
@zirain zirain merged commit e1772e4 into envoyproxy:main Mar 2, 2024
@zirain zirain deleted the timeout-e2e branch March 2, 2024 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

flaky: TestE2E/ClientTimeout

2 participants