fix: surface the status of listeners when MergeGateways enabled#2672
fix: surface the status of listeners when MergeGateways enabled#2672Xunzhuo merged 6 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: shawnh2 <shawnhxh@outlook.com>
|
/retest |
…us of all gateways under gatewayclass into a method Signed-off-by: shawnh2 <shawnhxh@outlook.com>
|
/retest |
|
|
||
| for _, gateway := range gateways.Items { | ||
| gateway := gateway | ||
| r.updateStatusForGateway(ctx, &gateway) | ||
| } | ||
|
|
There was a problem hiding this comment.
| for _, gateway := range gateways.Items { | |
| gateway := gateway | |
| r.updateStatusForGateway(ctx, &gateway) | |
| } | |
| if len(gateways.Items) > 0 { | |
| for _, gateway := range gateways.Items { | |
| gateway := gateway | |
| r.updateStatusForGateway(ctx, &gateway) | |
| } | |
| } |
There was a problem hiding this comment.
I don't think this extra check for the loop is necessary, since the loop will not start if gateways.Item is empty.
Instead I have added this check to return error if gateways.Item is empty, meaning no gateways found under the specific gatewayclass.
|
already answered here #2668 (comment) |
…ays under certain gatewayclass Signed-off-by: shawnh2 <shawnhxh@outlook.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2672 +/- ##
==========================================
+ Coverage 63.38% 63.43% +0.05%
==========================================
Files 119 119
Lines 19098 19477 +379
==========================================
+ Hits 12106 12356 +250
- Misses 6193 6323 +130
+ Partials 799 798 -1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: shawnh2 <shawnhxh@outlook.com>
Signed-off-by: shawnh2 <shawnhxh@outlook.com>
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #2668