add e2e test for http3 & fix ci error#2519
Conversation
Signed-off-by: A3bz <zeng921359373@163.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2519 +/- ##
==========================================
- Coverage 66.51% 63.50% -3.01%
==========================================
Files 161 125 -36
Lines 22673 20604 -2069
==========================================
- Hits 15080 13085 -1995
+ Misses 6720 6685 -35
+ Partials 873 834 -39 ☔ View full report in Codecov by Sentry. |
shawnh2
left a comment
There was a problem hiding this comment.
can you fix the linter, thanks
Signed-off-by: A3bz <zeng921359373@163.com>
Signed-off-by: A3bz <zeng921359373@163.com>
# Conflicts: # go.sum # test/e2e/base/manifests.yaml
Signed-off-by: A3bz <zeng921359373@163.com>
# Conflicts: # go.mod # go.sum
Signed-off-by: zesiar0 <zeng921359373@163.com>
# Conflicts: # go.mod # go.sum
Signed-off-by: zesiar0 <zeng921359373@163.com>
add pod bootstrap command Signed-off-by: A3bz <59257677+zesiar0@users.noreply.github.com>
resolve conflicts Signed-off-by: A3bz <59257677+zesiar0@users.noreply.github.com>
# Conflicts: # go.sum
# Conflicts: # go.mod # go.sum
|
@shawnh2 it seems that the error has nothing to do with my code |
|
/retest |
test/e2e/tests/http3.go
Outdated
| Tracer: qlog.DefaultTracer, | ||
| }, | ||
| Dial: func(ctx context.Context, addr string, tlsCfg *tls.Config, cfg *quic.Config) (quic.EarlyConnection, error) { | ||
| if addr == "www.example.com:443" { |
There was a problem hiding this comment.
does this addr has something to do with the server in L47? If so, can we turn it into a parameter? just to make this function more generic.
test/e2e/tests/http3.go
Outdated
| }, nil | ||
| } | ||
|
|
||
| func defaultRoundTrip(request roundtripper.Request, transport *http3.RoundTripper) (*roundtripper.CapturedRequest, *roundtripper.CapturedResponse, error) { |
There was a problem hiding this comment.
can you make all the name of these functions explicit with http3? may help others to know these functions are exclusive for HTTP3
test/e2e/tests/http3.go
Outdated
| }, | ||
| } | ||
|
|
||
| func CaptureRoundTrip(request roundtripper.Request, gwAddr string) (*roundtripper.CapturedRequest, *roundtripper.CapturedResponse, error) { |
There was a problem hiding this comment.
should we equip this with retry ability?
There was a problem hiding this comment.
why? It seems unnecessary and there is no such ability in sigs.k8s.io/gateway-api either
Signed-off-by: zesiar0 <zeng921359373@163.com>
# Conflicts: # go.sum
test/e2e/tests/http3.go
Outdated
| fmt.Printf("Sending Request:\n%s\n\n", formatDump(dumpReq, "<? ")) | ||
|
|
||
| var resp *httpv1.Response | ||
| err = retryv1.Do( |
There was a problem hiding this comment.
please kindly use httputils.AwaitConvergence from gatewayapi project, or retry from k8s.
let's keep consistency.
# Conflicts: # go.mod # go.sum # test/e2e/base/manifests.yaml
Signed-off-by: zesiar0 <zeng921359373@163.com>
# Conflicts: # go.mod # go.sum
Signed-off-by: zesiar0 <zeng921359373@163.com>
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions! |
|
@zesiar0 are you still working on this? |
|
closing this PR since its become inactive, feel free to reopen if you're still working on it |
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #2423