Skip to content

Implements xDS Server Config API#245

Closed
danehans wants to merge 2 commits intoenvoyproxy:mainfrom
danehans:issue_201_followup_impl
Closed

Implements xDS Server Config API#245
danehans wants to merge 2 commits intoenvoyproxy:mainfrom
danehans:issue_201_followup_impl

Conversation

@danehans
Copy link
Copy Markdown
Contributor

Manages Envoy xDS Server Address through the EnvoyProxy API.

  • Updates the infra IR to use EnvoyProxySpec instead of EnvoyProxy.
  • Updates the gatewayclass controller to manage parametersRef of accepted gatewayclass.
  • Plumbs the xdsServerAddress throughout the system.

Requires: #224

Signed-off-by: danehans <daneyonhansen@gmail.com>
Signed-off-by: danehans <daneyonhansen@gmail.com>
@danehans danehans requested a review from a team as a code owner August 25, 2022 17:50
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #245 (9dc1049) into main (d99f32f) will decrease coverage by 0.27%.
The diff coverage is 52.63%.

@@            Coverage Diff             @@
##             main     #245      +/-   ##
==========================================
- Coverage   57.62%   57.35%   -0.28%     
==========================================
  Files          30       30              
  Lines        2702     2755      +53     
==========================================
+ Hits         1557     1580      +23     
- Misses       1054     1081      +27     
- Partials       91       94       +3     
Impacted Files Coverage Δ
internal/envoygateway/config/config.go 0.00% <ø> (ø)
internal/ir/zz_generated.deepcopy.go 0.00% <0.00%> (ø)
internal/message/types.go 68.51% <0.00%> (-13.71%) ⬇️
internal/status/gatewayclass.go 0.00% <0.00%> (ø)
internal/provider/kubernetes/gatewayclass.go 65.27% <55.35%> (-3.63%) ⬇️
internal/ir/infra.go 68.13% <55.55%> (-3.11%) ⬇️
internal/gatewayapi/translator.go 86.07% <100.00%> (+0.02%) ⬆️
internal/infrastructure/kubernetes/deployment.go 82.38% <100.00%> (ø)
internal/status/conditions.go 95.00% <100.00%> (ø)
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@danehans
Copy link
Copy Markdown
Contributor Author

danehans commented Aug 25, 2022

Closing since we don't want to expose config to users in v0.2.0. This can be reopened or used as a reference EnvoyProxy API implementation in the future.

@danehans danehans closed this Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants