feat(translator): Implement BTP CircuitBreaker API#2330
feat(translator): Implement BTP CircuitBreaker API#2330arkodg merged 5 commits intoenvoyproxy:mainfrom
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2330 +/- ##
==========================================
- Coverage 64.72% 64.71% -0.01%
==========================================
Files 113 113
Lines 16445 16557 +112
==========================================
+ Hits 10644 10715 +71
- Misses 5130 5168 +38
- Partials 671 674 +3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
can we pass an extra errMsg to the func to add some more error msg details such as invalid maxPendingRequests value etc
|
the PR is looking really good, thanks for adding an e2e as well ! |
There was a problem hiding this comment.
can we add some test here? make sure int64ToUint32 works as expected
Xunzhuo
left a comment
There was a problem hiding this comment.
Thanks, this PR overall looks good ! Pretty clear. Would love to add more e2e tests and a user guide docs in a follow-up.
Signed-off-by: Guy Daich <guy.daich@sap.com>
Signed-off-by: Guy Daich <guy.daich@sap.com>
Signed-off-by: Guy Daich <guy.daich@sap.com>
Signed-off-by: Guy Daich <guy.daich@sap.com>
What type of PR is this?
Feature, implementation of API defined in #2284
What this PR does / why we need it:
Add support for configuring Envoy's circuit breaking settings.
Which issue(s) this PR fixes:
Fixes #2125