feat: proxy protocol in ClientTrafficPolicy#2203
Merged
zirain merged 3 commits intoenvoyproxy:mainfrom Nov 21, 2023
Merged
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2203 +/- ##
==========================================
+ Coverage 64.35% 64.40% +0.04%
==========================================
Files 109 110 +1
Lines 15302 15343 +41
==========================================
+ Hits 9848 9882 +34
- Misses 4845 4850 +5
- Partials 609 611 +2 ☔ View full report in Codecov by Sentry. |
0b4aac6 to
49427c8
Compare
Member
|
lgtm, is it possible to add e2e tests for this? |
zhaohuabing
reviewed
Nov 19, 2023
zhaohuabing
reviewed
Nov 19, 2023
zhaohuabing
approved these changes
Nov 19, 2023
Member
zhaohuabing
left a comment
There was a problem hiding this comment.
LGTM. Just a few small nits in comments.
zhaohuabing
approved these changes
Nov 19, 2023
Contributor
Author
@zirain should be possible, can do in a follow up PR using https://github.com/pires/go-proxyproto |
added 2 commits
November 20, 2023 13:38
relates to envoyproxy#1328 Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
22999d0 to
143768c
Compare
Member
|
/retest |
Member
|
I think this will confict with #2210 |
zirain
approved these changes
Nov 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relates to #1328