Generally, code looks good to me. Just two minor comments:

1. Minor name change comment
2. From this implementation, IP and FQDN weight based balancing is achieved. Do we still want to go with this simple approach here?

hi @EltonzHu , thanks for reviewing this. I haven't test this implementation yet, so it may not be right. If this implementation won't work, i will stick to the simple approach.

Generally, code looks good to me. Just two minor comments:

1. Minor name change comment
2. From this implementation, IP and FQDN weight based balancing is achieved. Do we still want to go with this simple approach here?

hi @EltonzHu , thanks for reviewing this. I haven't test this implementation yet, so it may not be right. If this implementation won't work, i will stick to the simple approach.

Sounds good. FYI, please be aware of this issue opened and proposed solution with explicit locality setting on LB weights.

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (532709c) 64.26% compared to head (1d01804) 64.41%.
Report is 1 commits behind head on main.

@@            Coverage Diff             @@
##             main    #2138      +/-   ##
==========================================
+ Coverage   64.26%   64.41%   +0.15%     
==========================================
  Files         112      112              
  Lines       15728    15796      +68     
==========================================
+ Hits        10107    10175      +68     
  Misses       4980     4980              
  Partials      641      641              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

make gen-check is failing, you can run make testdata to rewrite test files

few nits, else looks good, thanks !
cc @zirain

/retest