LoadBalancer in BackendTrafficPolicy#2063
Merged
arkodg merged 2 commits intoenvoyproxy:mainfrom Oct 25, 2023
Merged
Conversation
Fixes: envoyproxy#1105 Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Codecov Report
@@ Coverage Diff @@
## main #2063 +/- ##
==========================================
+ Coverage 65.03% 65.07% +0.04%
==========================================
Files 99 99
Lines 14536 14578 +42
==========================================
+ Hits 9453 9487 +34
- Misses 4496 4504 +8
Partials 587 587
|
zirain
reviewed
Oct 25, 2023
zhaohuabing
reviewed
Oct 25, 2023
| // set to ConsistentHash | ||
| // | ||
| // +optional | ||
| ConsistentHash *ConsistentHash `json:"consistentHash,omitempty"` |
Member
There was a problem hiding this comment.
-
What happens if the type is
ConsistentHashand theConsistentHashis nil? -
If Source IP is the only hash source we would like to support now, maybe just remove the
ConsistentHashproperty and add a comment, or we can add another common-used hash source, like headers.
Contributor
Author
There was a problem hiding this comment.
this is what @zirain is referring to in #2063 (comment)
we can add CEL Validation to proactively check this
zirain
approved these changes
Oct 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #1105