Merged
Conversation
Takes PR envoyproxy#1961 forward Signed-off-by: Arko Dasgupta <arko@tetrate.io>
This was referenced Oct 23, 2023
Codecov Report
@@ Coverage Diff @@
## main #2053 +/- ##
==========================================
+ Coverage 65.18% 65.22% +0.04%
==========================================
Files 95 97 +2
Lines 13947 14199 +252
==========================================
+ Hits 9091 9261 +170
- Misses 4286 4363 +77
- Partials 570 575 +5
|
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Alice-Lilith
previously approved these changes
Oct 23, 2023
Member
Alice-Lilith
left a comment
There was a problem hiding this comment.
Thanks for taking this forward 🙏
Alice-Lilith
previously approved these changes
Oct 24, 2023
zirain
previously approved these changes
Oct 24, 2023
| - There can be only be ONE policy resource attached to a specific `Listener` (section) within a `Gateway` | ||
| - If the policy targets a resource but cannot attach to it, this information should be reflected | ||
| in the Policy Status field using the `Conflicted=True` condition. | ||
| - If multiple polices target the same resource, the oldest resource (based on creation timestamp) will |
Member
There was a problem hiding this comment.
just want to make sure all EG's CRD follow same rule.
Contributor
Author
There was a problem hiding this comment.
yes all policies follow similar rule
Co-authored-by: zirain <zirain2009@gmail.com> Signed-off-by: Arko Dasgupta <arkodg@users.noreply.github.com>
Co-authored-by: zirain <zirain2009@gmail.com> Signed-off-by: Arko Dasgupta <arkodg@users.noreply.github.com>
zirain
approved these changes
Oct 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Takes PR #1961 forward