feat: add field allocateLoadBalancerNodePorts to KubernetesServiceSpec#1893
Merged
zirain merged 5 commits intoenvoyproxy:mainfrom Sep 19, 2023
den3tsou:main
Merged
feat: add field allocateLoadBalancerNodePorts to KubernetesServiceSpec#1893zirain merged 5 commits intoenvoyproxy:mainfrom den3tsou:main
zirain merged 5 commits intoenvoyproxy:mainfrom
den3tsou:main
Conversation
This commit adds a new field allocateLoadBalancerNodePorts to KubernetesServiceSpec. But this field can only be set when the service type is 'LoadBalancer' Signed-off-by: Den Tsou <den3tsou@gmail.com>
den3tsou
commented
Sep 17, 2023
Contributor
Author
There was a problem hiding this comment.
Is there any good place for this kind of help function?
Contributor
There was a problem hiding this comment.
Codecov Report
@@ Coverage Diff @@
## main #1893 +/- ##
==========================================
+ Coverage 66.12% 66.15% +0.02%
==========================================
Files 86 86
Lines 12868 12876 +8
==========================================
+ Hits 8509 8518 +9
+ Misses 3832 3830 -2
- Partials 527 528 +1
|
arkodg
reviewed
Sep 18, 2023
arkodg
reviewed
Sep 18, 2023
Signed-off-by: Den Tsou <den3tsou@gmail.com>
…lancerNodePorts Signed-off-by: Den Tsou <den3tsou@gmail.com>
Signed-off-by: Den Tsou <den3tsou@gmail.com>
zirain
approved these changes
Sep 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds field
allocateLoadBalancerNodePortsto KubernetesServiceSpec for Envoy Proxy kind. The value will get propagated to the Envoy Proxy Sevice configuration, so users can choose to not use automatically assignedNodePortsby settingfalsefor this field. Please see ServiceSpec v1 core for more info.Which issue(s) this PR fixes:
Fixes #1772