update cherry-pick GHA for v0.5#1714
Merged
zirain merged 1 commit intoenvoyproxy:mainfrom Jul 27, 2023
Merged
Conversation
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Codecov Report
@@ Coverage Diff @@
## main #1714 +/- ##
==========================================
- Coverage 64.90% 64.79% -0.12%
==========================================
Files 83 83
Lines 11912 11912
==========================================
- Hits 7732 7718 -14
- Misses 3701 3711 +10
- Partials 479 483 +4 |
zirain
approved these changes
Jul 27, 2023
Xunzhuo
approved these changes
Jul 27, 2023
Member
Xunzhuo
left a comment
There was a problem hiding this comment.
If so, we can not cp commits into v0.4 and cherrypick/release-v0.4 won`t work anymore ?
Thoughts on adding instead of replacing ?
Member
|
maybe we change upstream tool, make it more generic? |
Contributor
Author
|
@Xunzhuo, in the future once we support patch versions we will need to keep steps for each minor release, right now we are only supporting v0.x.0 releases, I think it's safe to replace |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Arko Dasgupta arko@tetrate.io