feat: EnvoyPatchPolicy Status#1691
Merged
arkodg merged 12 commits intoenvoyproxy:mainfrom Jul 26, 2023
Merged
Conversation
Contributor
Author
|
hey @Xunzhuo |
6 tasks
Codecov Report
@@ Coverage Diff @@
## main #1691 +/- ##
==========================================
- Coverage 60.45% 60.31% -0.14%
==========================================
Files 86 87 +1
Lines 12737 12912 +175
==========================================
+ Hits 7700 7788 +88
- Misses 4541 4632 +91
+ Partials 496 492 -4
|
added 10 commits
July 25, 2023 15:28
* compute the `Accepted` condition in the `gateway-api` layer * compute the `Programmed` condition in the `xds-translator` layer * Enhance Xds IR to hold the EnvoyPatchPolicy status * Publish the EnvoyPatchPolicy status from the `xds-translator` layer * `provider` subscribes to the status and writes it into the API server Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
* add status for empty path case * refactor ir for envoy patch policy status * test cases for patch policy status in xds-translator layer Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Member
Alice-Lilith
left a comment
There was a problem hiding this comment.
Small question but otherwise lgtm
|
|
||
| package ptr | ||
|
|
||
| func To[T any](in T) *T { |
Member
There was a problem hiding this comment.
We should use this to clean up a bunch of the misc test files at some point that declare a ton of ints just to pass the pointer when declareing xDS in-line.
Contributor
Author
There was a problem hiding this comment.
sg, will raise a issue for this
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Alice-Lilith
approved these changes
Jul 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
compute the
Acceptedcondition in thegateway-apilayercompute the
Programmedcondition in thexds-translatorlayerEnhance Xds IR to hold the EnvoyPatchPolicy status
Publish the EnvoyPatchPolicy status from the
xds-translatorlayerprovidersubscribes to the status and writes it into the API serverRelates to #24