Use / to create internal IR names instead of -#1681
Merged
Xunzhuo merged 1 commit intoenvoyproxy:mainfrom Jul 20, 2023
Merged
Conversation
* Also had to replace `/` with `-` when creating K8s resource names :) Fixes: envoyproxy#1640 Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Contributor
Author
|
thanks for creating |
Codecov Report
@@ Coverage Diff @@
## main #1681 +/- ##
==========================================
+ Coverage 60.78% 60.90% +0.11%
==========================================
Files 84 84
Lines 12575 12575
==========================================
+ Hits 7644 7659 +15
+ Misses 4436 4424 -12
+ Partials 495 492 -3
|
Closed
Contributor
Author
|
/retest |
zirain
reviewed
Jul 20, 2023
Member
zirain
left a comment
There was a problem hiding this comment.
lgtm, @envoyproxy/gateway-maintainers ptal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/with-when creating K8s resource names :)Relates to #1640