Merged
Conversation
Relates to envoyproxy#1117 Signed-off-by: Arko Dasgupta <arko@tetrate.io>
6 tasks
Codecov Report
@@ Coverage Diff @@
## main #1610 +/- ##
==========================================
+ Coverage 61.86% 61.98% +0.12%
==========================================
Files 81 81
Lines 12032 12036 +4
==========================================
+ Hits 7443 7460 +17
+ Misses 4131 4121 -10
+ Partials 458 455 -3
|
zirain
reviewed
Jul 3, 2023
| svr.EnvoyGateway.Provider.Kubernetes != nil && | ||
| (svr.EnvoyGateway.Provider.Kubernetes.Watch != nil) && | ||
| (len(svr.EnvoyGateway.Provider.Kubernetes.Watch.Namespaces) > 0) { | ||
| mgrOpts.Cache.Namespaces = svr.EnvoyGateway.Provider.Kubernetes.Watch.Namespaces |
Member
There was a problem hiding this comment.
will EG only get resources from WatchNamespaces?
Contributor
Author
There was a problem hiding this comment.
yes if this field is set, the test case reflects this
Closed
zirain
approved these changes
Jul 3, 2023
qicz
approved these changes
Jul 4, 2023
Member
qicz
left a comment
There was a problem hiding this comment.
it's great, it is better for EG memory occupied.
LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #1117