Skip to content

e2e: improve accesslog tests#1599

Merged
arkodg merged 1 commit intoenvoyproxy:mainfrom
zirain:improve-accesslog-e2e
Jun 27, 2023
Merged

e2e: improve accesslog tests#1599
arkodg merged 1 commit intoenvoyproxy:mainfrom
zirain:improve-accesslog-e2e

Conversation

@zirain
Copy link
Copy Markdown
Member

@zirain zirain commented Jun 27, 2023

see #1563 (comment), split HttpRoute for differnet tests

fixes: #1563

Signed-off-by: hejianpeng <hejianpeng2@huawei.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 27, 2023

Codecov Report

Merging #1599 (418dd6e) into main (278e02f) will decrease coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1599      +/-   ##
==========================================
- Coverage   61.83%   61.76%   -0.08%     
==========================================
  Files          81       81              
  Lines       12032    12032              
==========================================
- Hits         7440     7431       -9     
- Misses       4134     4141       +7     
- Partials      458      460       +2     

see 2 files with indirect coverage changes

Copy link
Copy Markdown
Member

@qicz qicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arkodg arkodg merged commit d83510c into envoyproxy:main Jun 27, 2023
@zirain zirain deleted the improve-accesslog-e2e branch June 28, 2023 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

flaky: TestE2E/OpenTelemetryAccessLog

3 participants