Skip to content

e2e: fix OpenTelemetryAccessLog flaky#1585

Merged
zirain merged 1 commit intoenvoyproxy:mainfrom
zirain:e2e-accesslog
Jun 26, 2023
Merged

e2e: fix OpenTelemetryAccessLog flaky#1585
zirain merged 1 commit intoenvoyproxy:mainfrom
zirain:e2e-accesslog

Conversation

@zirain
Copy link
Copy Markdown
Member

@zirain zirain commented Jun 25, 2023

fixes: #1563

Signed-off-by: hejianpeng <hejianpeng2@huawei.com>
@zirain zirain marked this pull request as ready for review June 25, 2023 07:39
@zirain zirain requested a review from a team as a code owner June 25, 2023 07:39
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 25, 2023

Codecov Report

Merging #1585 (5b6da76) into main (ad3331d) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1585      +/-   ##
==========================================
- Coverage   61.79%   61.76%   -0.04%     
==========================================
  Files          81       81              
  Lines       12018    12018              
==========================================
- Hits         7427     7423       -4     
- Misses       4133     4137       +4     
  Partials      458      458              

see 2 files with indirect coverage changes

Copy link
Copy Markdown
Member

@qicz qicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zirain zirain merged commit 5554b8c into envoyproxy:main Jun 26, 2023
@zirain zirain deleted the e2e-accesslog branch June 26, 2023 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

flaky: TestE2E/OpenTelemetryAccessLog

3 participants