Skip to content

feat: add API for Deployment Mode#1413

Merged
zirain merged 3 commits intoenvoyproxy:mainfrom
arkodg:mode-watch-ns
May 17, 2023
Merged

feat: add API for Deployment Mode#1413
zirain merged 3 commits intoenvoyproxy:mainfrom
arkodg:mode-watch-ns

Conversation

@arkodg
Copy link
Copy Markdown
Contributor

@arkodg arkodg commented May 10, 2023

Relates to #1117

apiVersion: config.gateway.envoyproxy.io/v1alpha1
kind: EnvoyGateway
gateway:
  controllerName: gateway.envoyproxy.io/gatewayclass-controller
provider:
  type: Kubernetes
  kubernetes:
    watch:
      namespaces:
      - "ns-1"
      - "ns-2"

Relates to envoyproxy#1117

```
apiVersion: config.gateway.envoyproxy.io/v1alpha1
kind: EnvoyGateway
gateway:
  controllerName: gateway.envoyproxy.io/gatewayclass-controller
provider:
  type: Kubernetes
  kubernetes:
    mode:
      watch:
        namespaces:
	- "ns-1"
	- "ns-2"
```

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@arkodg arkodg requested a review from a team as a code owner May 10, 2023 05:01
@codecov
Copy link
Copy Markdown

codecov bot commented May 10, 2023

Codecov Report

Merging #1413 (5a9065d) into main (b90946c) will decrease coverage by 0.68%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1413      +/-   ##
==========================================
- Coverage   62.63%   61.95%   -0.68%     
==========================================
  Files          79       79              
  Lines       11116    11293     +177     
==========================================
+ Hits         6962     6997      +35     
- Misses       3699     3836     +137     
- Partials      455      460       +5     
Impacted Files Coverage Δ
api/config/v1alpha1/envoygateway_types.go 100.00% <ø> (ø)
api/config/v1alpha1/zz_generated.deepcopy.go 0.00% <0.00%> (ø)

... and 7 files with indirect coverage changes

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
fix
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Copy link
Copy Markdown
Contributor

@haq204 haq204 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable to me

@zirain zirain added the cherrypick/release-v0.4 cherrypick to release/v0.4 label May 17, 2023
@zirain
Copy link
Copy Markdown
Member

zirain commented May 17, 2023

add a label for testing

@zirain zirain merged commit efe575a into envoyproxy:main May 17, 2023
@arkodg arkodg deleted the mode-watch-ns branch May 22, 2023 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherrypick/release-v0.4 cherrypick to release/v0.4

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants