Skip to content

feat: Add API for Custom provider#1402

Merged
zirain merged 3 commits intoenvoyproxy:mainfrom
arkodg:custom-provider-api
May 11, 2023
Merged

feat: Add API for Custom provider#1402
zirain merged 3 commits intoenvoyproxy:mainfrom
arkodg:custom-provider-api

Conversation

@arkodg
Copy link
Copy Markdown
Contributor

@arkodg arkodg commented May 6, 2023

Relates to #1393

Relates to envoyproxy#1393

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@arkodg arkodg requested a review from a team as a code owner May 6, 2023 00:01
@arkodg arkodg mentioned this pull request May 6, 2023
5 tasks
@codecov
Copy link
Copy Markdown

codecov bot commented May 6, 2023

Codecov Report

Merging #1402 (7ad5752) into main (b90946c) will decrease coverage by 0.32%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1402      +/-   ##
==========================================
- Coverage   62.63%   62.31%   -0.32%     
==========================================
  Files          79       79              
  Lines       11116    11169      +53     
==========================================
- Hits         6962     6960       -2     
- Misses       3699     3753      +54     
- Partials      455      456       +1     
Impacted Files Coverage Δ
api/config/v1alpha1/envoygateway_types.go 100.00% <ø> (ø)
api/config/v1alpha1/zz_generated.deepcopy.go 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

@qicz
Copy link
Copy Markdown
Member

qicz commented May 6, 2023

word spell error

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Copy link
Copy Markdown
Contributor

@kflynn kflynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The API content looks good to me – how 'bout some user-facing doc? 🙂

@arkodg
Copy link
Copy Markdown
Contributor Author

arkodg commented May 9, 2023

The API content looks good to me – how 'bout some user-facing doc? 🙂

@kflynn should be here https://gateway.envoyproxy.io/latest/design/local-envoy-gateway.html
user facing docs are being tracked with #1393 and should be completed once the implementation is ready :)

Copy link
Copy Markdown
Member

@Alice-Lilith Alice-Lilith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API looks good to me

@zirain zirain merged commit 5f222eb into envoyproxy:main May 11, 2023
@arkodg arkodg deleted the custom-provider-api branch June 1, 2023 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants