Skip to content

feat: set tcp proxy listener buffer#1306

Merged
zirain merged 1 commit intoenvoyproxy:mainfrom
Xunzhuo:issue-1048
Apr 18, 2023
Merged

feat: set tcp proxy listener buffer#1306
zirain merged 1 commit intoenvoyproxy:mainfrom
Xunzhuo:issue-1048

Conversation

@Xunzhuo
Copy link
Copy Markdown
Member

@Xunzhuo Xunzhuo commented Apr 14, 2023

Part of: #1048

@Xunzhuo Xunzhuo requested a review from a team as a code owner April 14, 2023 03:16
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 14, 2023

Codecov Report

Merging #1306 (632bf13) into main (6baaaf1) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1306      +/-   ##
==========================================
- Coverage   61.88%   61.83%   -0.06%     
==========================================
  Files          85       85              
  Lines       10852    10853       +1     
==========================================
- Hits         6716     6711       -5     
- Misses       3692     3697       +5     
- Partials      444      445       +1     
Impacted Files Coverage Δ
internal/xds/translator/listener.go 81.57% <100.00%> (+0.05%) ⬆️

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should EG support to custom this?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets raise a issue for this ? #24 is always a back up option

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If so, we need to add new apis in envoyproxy too, let us keep it in this way, unless someone requests for it.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Signed-off-by: bitliu <bitliu@tencent.com>
Copy link
Copy Markdown
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@haorenfsa
Copy link
Copy Markdown
Contributor

haorenfsa commented Aug 19, 2024

Em... I just tried on v1.1.0, seems not work for me. I add a BackendTrafficPolicy but the per_connection_buffer_limit_bytes is still 32KB

OK, I found that ClientTrafficPolicy should also be set.

@arkodg
Copy link
Copy Markdown
Contributor

arkodg commented Aug 19, 2024

Add a knob to make per_connection_buffer_limit_bytes configurable #2600

cc @yaelSchechter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants