Conversation
Codecov Report
@@ Coverage Diff @@
## main #1239 +/- ##
==========================================
+ Coverage 62.34% 62.51% +0.17%
==========================================
Files 78 78
Lines 10973 10973
==========================================
+ Hits 6841 6860 +19
+ Misses 3680 3664 -16
+ Partials 452 449 -3 |
|
thanks @zirain, this PR is a massive addition for the project to improve e2e and reduce regressions for our Extension APIs |
|
thanks for addressing comments @zirain , this PR adds a fork for the gateway-api repo which im hoping we dont need, and the upstream PR you raised is merged and can be brought in to this project soon |
yes, we should not include my fork repo. let's wait upstream PR merged. |
|
another option is to write our own utils/suite package and we can write a custom |
unless kubernetes-sigs/gateway-api#1899 is unacceptable. |
Signed-off-by: hejianpeng <hejianpeng2@huawei.com>
Signed-off-by: hejianpeng <hejianpeng2@huawei.com>
Signed-off-by: hejianpeng <hejianpeng2@huawei.com>
Signed-off-by: hejianpeng <hejianpeng2@huawei.com>
Signed-off-by: hejianpeng <hejianpeng2@huawei.com>
Signed-off-by: hejianpeng <hejianpeng2@huawei.com>
Signed-off-by: hejianpeng <hejianpeng2@huawei.com>
Signed-off-by: hejianpeng <hejianpeng2@huawei.com>
Signed-off-by: hejianpeng <hejianpeng2@huawei.com>
|
cc @arkodg , this's ready to go, PTAL. |
| kubectl rollout restart deployment envoy-gateway -n envoy-gateway-system | ||
| kubectl wait --timeout=5m -n envoy-gateway-system deployment/envoy-gateway --for=condition=Available | ||
|
|
||
| .PHONY: run-e2e |
There was a problem hiding this comment.
How about run-e2e-ratelimit ? Since we might need to add other e2e tests like auth, etc.
There was a problem hiding this comment.
this's the entrypoint for all e2e tests, for now there's only ratelimit tests
| .PHONY: install-ratelimit | ||
| install-ratelimit: | ||
| @$(LOG_TARGET) | ||
| kubectl apply -f examples/redis/redis.yaml |
There was a problem hiding this comment.
only nit here would be to split up redis install with patching/updating the EnvoyGateway Configmap, but it can be improved later
arkodg
left a comment
There was a problem hiding this comment.
LGTM thanks for adding the e2e infra, should give us more confidence while building out extended features
init e2e test base on gateway-api conformance test suite, related to kubernetes-sigs/gateway-api#1899
Fixes: #863
cc @arkodg