Merged
Conversation
Signed-off-by: hejianpeng <hejianpeng2@huawei.com>
2 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1233 +/- ##
==========================================
+ Coverage 63.26% 63.52% +0.26%
==========================================
Files 79 79
Lines 9829 9893 +64
==========================================
+ Hits 6218 6285 +67
+ Misses 3192 3190 -2
+ Partials 419 418 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
arkodg
reviewed
Mar 28, 2023
arkodg
reviewed
Mar 28, 2023
arkodg
reviewed
Mar 28, 2023
arkodg
reviewed
Mar 28, 2023
arkodg
reviewed
Mar 28, 2023
Co-authored-by: Arko Dasgupta <arkodg@users.noreply.github.com> Signed-off-by: zirain <hejianpeng2@huawei.com>
Co-authored-by: Arko Dasgupta <arkodg@users.noreply.github.com> Signed-off-by: zirain <hejianpeng2@huawei.com>
Co-authored-by: Arko Dasgupta <arkodg@users.noreply.github.com> Signed-off-by: zirain <hejianpeng2@huawei.com>
Co-authored-by: Arko Dasgupta <arkodg@users.noreply.github.com> Signed-off-by: zirain <hejianpeng2@huawei.com>
Co-authored-by: Arko Dasgupta <arkodg@users.noreply.github.com> Signed-off-by: zirain <hejianpeng2@huawei.com>
Xunzhuo
approved these changes
Mar 29, 2023
arkodg
approved these changes
Mar 29, 2023
Contributor
arkodg
left a comment
There was a problem hiding this comment.
LGTM, thanks for adding the doc !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xref: #1144
cc @arkodg