Skip to content

fix PathSeparatedPrefix & optimize the prefix ends with / logic.#1125

Merged
Xunzhuo merged 1 commit intoenvoyproxy:mainfrom
qicz:support-1044
Mar 12, 2023
Merged

fix PathSeparatedPrefix & optimize the prefix ends with / logic.#1125
Xunzhuo merged 1 commit intoenvoyproxy:mainfrom
qicz:support-1044

Conversation

@qicz
Copy link
Copy Markdown
Member

@qicz qicz commented Mar 10, 2023

fix & support #1044

the upstream receive double "/" needs envoy fix , issue envoyproxy/envoy#26024

@qicz qicz requested a review from a team as a code owner March 10, 2023 03:28
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 10, 2023

Codecov Report

Merging #1125 (6f07161) into main (38470e0) will increase coverage by 0.41%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #1125      +/-   ##
==========================================
+ Coverage   62.51%   62.93%   +0.41%     
==========================================
  Files          72       72              
  Lines        9509     9528      +19     
==========================================
+ Hits         5945     5996      +51     
+ Misses       3152     3124      -28     
+ Partials      412      408       -4     
Impacted Files Coverage Δ
internal/xds/translator/route.go 90.62% <100.00%> (+9.54%) ⬆️

... and 4 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@qicz qicz changed the title fix PathSeparatedPrefix & optimize prefix endwith / logic fix PathSeparatedPrefix & optimize the prefix ends with / logic. Mar 11, 2023
@qicz qicz requested a review from arkodg March 11, 2023 00:12
@qicz
Copy link
Copy Markdown
Member Author

qicz commented Mar 11, 2023

@arkodg resolved all, pls review again.

Copy link
Copy Markdown
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @qicz !

Copy link
Copy Markdown
Member

@Xunzhuo Xunzhuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Xunzhuo Xunzhuo merged commit 96d6e2a into envoyproxy:main Mar 12, 2023
@arkodg arkodg mentioned this pull request Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants