Allow user to configure annotations on infra#1115
Merged
Xunzhuo merged 3 commits intoenvoyproxy:mainfrom Mar 9, 2023
Merged
Conversation
This PR allows the user to add annotations to the managed Envoy service and well as the Envoy pods using the EnvoyProxy resource * Fixes envoyproxy#377 * Closes envoyproxy#648 Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1115 +/- ##
==========================================
+ Coverage 62.33% 62.44% +0.11%
==========================================
Files 72 72
Lines 9449 9509 +60
==========================================
+ Hits 5890 5938 +48
- Misses 3151 3157 +6
- Partials 408 414 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zirain
reviewed
Mar 9, 2023
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
zirain
approved these changes
Mar 9, 2023
Contributor
Author
|
thanks @zirain , hoping to get another approval before merging this API change |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows the user to add annotations to the
managed Envoy service and well as the Envoy pods using the EnvoyProxy resource
Fixes Add k8s annotations to the Envoy Proxy Service #377
Closes Add Support for Managing the Envoy Proxy Service #648