Run make inside a container with dev tools#102
Merged
arkodg merged 3 commits intoenvoyproxy:mainfrom Jun 10, 2022
Merged
Conversation
* Adds an option `MAKE_IN_DOCKER=1 make <target>` to allow the dev to run the make target inside a container with preinstalled dev tools * By default `MAKE_IN_DOCKER` is unset, so `make` would run locally on the host Relates to envoyproxy#90 Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Codecov Report
@@ Coverage Diff @@
## main #102 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 5 5
=========================================
Hits 5 5 Continue to review full report at Codecov.
|
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
lizan
reviewed
Jun 10, 2022
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
lizan
approved these changes
Jun 10, 2022
alexgervais
approved these changes
Jun 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an option
MAKE_IN_DOCKER=1 make <target>to allow the dev to run the make target inside a container
with preinstalled dev tools
By default
MAKE_IN_DOCKERis unset, somakewould runlocally on the host
Relates to #90
Signed-off-by: Arko Dasgupta arko@tetrate.io