-
Notifications
You must be signed in to change notification settings - Fork 709
Description
Description:
Use Case: I want to disable x-envoy-ratelimited header which is being set when a request is rate limited, as I do not need it and it doesn't really bring additional information about the ratelimit (correct me if that header is needed for something else).
Problem:
-
I tried the approach of removing the header using a HTTPRoute filter but the header doesn't get removed, which I am not entirely sure why, as the documentation mentions, that in the default filter chain the header modification filter is executed after the ratelimit one (which supposedly sets the header). My other assumption is that the filter set in the
HTTPRoutecan't re-write the header, as this is not a response from a service that is being intercepted, but that response is generate by a call to theratelimitservice, which potentially bypasses the response modification filters? -
I found that the
fiter.ratelimitdoes have an option to disable setting the header (linked the PR below), but that option is not exposed & it seems the only way to enable it is to useEnvoyPatchPolicywhich is not something my organisation wants to use due to it's instability -
There is the possibility to disable all
x-envoy-*headers, but I don't want to disable all of the headers just this one. -
The
ratelimitservice does have the option to add custom headers, but thex-envoy-ratelimitedseems to not be set in it.
Solution:
- Add a configuration option that would allow disabling the
x-envoy-ratelimitedfilter without usingEnvoyPatchPolicy
[optional Relevant Links:]