-
Notifications
You must be signed in to change notification settings - Fork 709
Some XDS resources are not validated #4504
Copy link
Copy link
Closed
Description
Description:
EG currently validates all XDS resources added to the resource table:
| func (t *ResourceVersionTable) AddXdsResource(rType resourcev3.Type, xdsResource types.Resource) error { |
However, it seems that some resources (and/or subresources) are not really getting validated, as described in #4457 (comment)
@zhaohuabing mentioned in the community meeting that resource that are turned to protobuf Any in the translator essentially shed away their go-control-plane validators. It was proposed to scan the entire codebase for all usages of Any and ensure that a validate is being called prior just-before the transformation. Perhaps it makes sense to embed the validation in our protocov util.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
kind/bugSomething isn't workingSomething isn't working