-
Notifications
You must be signed in to change notification settings - Fork 710
EnvoyGateway rateLimitDeployment ignores pod labels #4226
Copy link
Copy link
Closed
Labels
kind/bugSomething isn't workingSomething isn't workingprovider/kubernetesIssues related to the Kubernetes providerIssues related to the Kubernetes provider
Milestone
Description
Description:
When configuring the rate limit deployment through the envoy-gateway-config configmap, the provider.kubernetes.rateLimitDeployment.pod.labels field is ignored.
Other fields at the same level like annotations are respected.
Repro steps:
-
gateway v1.1 (experimental channel)
-
envoy-gateway installed through helm chart v0.0.0-latest
-
create GatewayClass with envoy controller.
-
Update
envoy-gateway-configconfigmap inenvoy-gateway-systemnamespace with the following values:apiVersion: v1 kind: ConfigMap metadata: name: envoy-gateway-config namespace: envoy-gateway-system data: envoy-gateway.yaml: | apiVersion: gateway.envoyproxy.io/v1alpha1 kind: EnvoyGateway provider: type: Kubernetes kubernetes: rateLimitDeployment: replicas: 4 pod: labels: my-label: test annotations: test-anno: test gateway: controllerName: gateway.envoyproxy.io/gatewayclass-controller rateLimit: backend: type: Redis redis: url: redis.redis-system.svc.cluster.local:6379 telemetry: metrics: prometheus: disable: false ``` -
Rollout restart envoy-gateway deployment for it to pick up the changes.
-
Deployment envoy-ratelimit has the annotation
test-anno: testin the pod spec, but not the labelmy-label: test
Environment:
- gateway v1.1 (experimental channel)
- envoy-gateway installed through helm chart v0.0.0-latest
- image gw controller: docker.io/envoyproxy/gateway-dev:latest
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
kind/bugSomething isn't workingSomething isn't workingprovider/kubernetesIssues related to the Kubernetes providerIssues related to the Kubernetes provider