fix: panic when using nil xdsRouteAction (#2104)

Xunzhuo · web-flow · commit 77445dec77f1 · 2023-10-28T08:57:59.000-07:00
Signed-off-by: bitliu &lt;bitliu@tencent.com&gt;
diff --git a/internal/xds/translator/ratelimit.go b/internal/xds/translator/ratelimit.go
@@ -128,7 +128,7 @@ func (t *Translator) buildRateLimitFilter(irListener *ir.HTTPListener) *hcmv3.Ht
 // patchRouteWithRateLimit builds rate limit actions and appends to the route.
 func patchRouteWithRateLimit(xdsRouteAction *routev3.RouteAction, irRoute *ir.HTTPRoute) error { //nolint:unparam
 	// Return early if no rate limit config exists.
-	if irRoute.RateLimit == nil || irRoute.RateLimit.Global == nil {
+	if irRoute.RateLimit == nil || irRoute.RateLimit.Global == nil || xdsRouteAction == nil {
 		return nil
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -128,7 +128,7 @@ func (t Translator) buildRateLimitFilter(irListener ir.HTTPListener) *hcmv3.Ht`
`128`	`128`	`// patchRouteWithRateLimit builds rate limit actions and appends to the route.`
`129`	`129`	`func patchRouteWithRateLimit(xdsRouteAction routev3.RouteAction, irRoute ir.HTTPRoute) error { //nolint:unparam`
`130`	`130`	`// Return early if no rate limit config exists.`
`131`		`- if irRoute.RateLimit == nil \|\| irRoute.RateLimit.Global == nil {`
	`131`	`+ if irRoute.RateLimit == nil \|\| irRoute.RateLimit.Global == nil \|\| xdsRouteAction == nil {`
`132`	`132`	`return nil`
`133`	`133`	`}`
`134`	`134`