Skip to content

Commit 33159b5

Browse files
author
Arko Dasgupta
committed
disable HTTPRouteRedirectPortAndScheme
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
1 parent cd19897 commit 33159b5

2 files changed

Lines changed: 3 additions & 10 deletions

File tree

internal/gatewayapi/route.go

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -525,16 +525,6 @@ func (t *Translator) processHTTPRouteParentRefListener(route RouteContext, route
525525
}
526526

527527
for _, routeRoute := range routeRoutes {
528-
// Set redirect port to listener port when redirect port and scheme is
529-
// unspecified
530-
/*
531-
if routeRoute.Redirect != nil &&
532-
routeRoute.Redirect.Port == nil &&
533-
routeRoute.Redirect.Scheme == nil {
534-
port := uint32(listener.Port)
535-
routeRoute.Redirect.Port = &port
536-
}
537-
*/
538528
hostRoute := &ir.HTTPRoute{
539529
Name: fmt.Sprintf("%s-%s", routeRoute.Name, host),
540530
PathMatch: routeRoute.PathMatch,

test/conformance/conformance_test.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,9 @@ func TestGatewayAPIConformance(t *testing.T) {
4141
CleanupBaseResources: *flags.CleanupBaseResources,
4242
SupportedFeatures: suite.AllFeatures,
4343
ExemptFeatures: suite.MeshCoreFeatures,
44+
SkipTests: []string{
45+
tests.HTTPRouteRedirectPortAndScheme.ShortName,
46+
},
4447
})
4548
cSuite.Setup(t)
4649
cSuite.Run(t, tests.ConformanceTests)

0 commit comments

Comments
 (0)