Skip to content
This repository was archived by the owner on Dec 16, 2020. It is now read-only.

wasm: restructure wasm test flakes for bazel build#488

Closed
Shikugawa wants to merge 11 commits intoenvoyproxy:masterfrom
Shikugawa:wasm-bazel-1
Closed

wasm: restructure wasm test flakes for bazel build#488
Shikugawa wants to merge 11 commits intoenvoyproxy:masterfrom
Shikugawa:wasm-bazel-1

Conversation

@Shikugawa
Copy link
Member

@Shikugawa Shikugawa commented Apr 21, 2020 •
edited
Loading

Signed-off-by: shikugawa Shikugawa@gmail.com

For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md

Description: This is a part of cleanup of wasm build with bazel. I'm planning to restructure directories related with wasm for testing like below.

test/extensions/
  └ wasm_data/
        ├ WORKSPACE
        ├ .bazelrc
        ├ BUILD
        ├ bazel            # bazel settings
        ├ access_loggers   # moved from test/extensions/access_loggers/wasm/test_data
	├ common           # moved from test/extensions/common/wasm/test_data
	├ functionality    # moved from test/extensions/wasm/test_data
        └ filter
           ├ network       # L4 wasm filters
           └ http          # L7 wasm filters
  • null_plugin build
  • proxy_wasm in Rust build with bazel
  • bazel in bazel approach to build them from root
  • test all of wasm with single bazel command. build wasm and test

Risk Level: Low
Testing:
Docs Changes:
Release Notes:
[Optional Fixes #Issue]
[Optional Deprecated:]

@Shikugawa
restructure for bazel
0a5d0ba 
Signed-off-by: shikugawa <Shikugawa@gmail.com>
@Shikugawa Shikugawa changed the title wasm: restructure for bazel build wasm: restructure wasm test flakes for bazel build Apr 21, 2020
@PiotrSikora
Copy link
Contributor

PiotrSikora commented Apr 23, 2020

What's the purpose of this change?

@Shikugawa
Copy link
Member Author

Shikugawa commented Apr 23, 2020 •
edited
Loading

@PiotrSikora This is only cleanup. It seems that we will be suffered from the complexity of the directory structure for wasm for testing. I think that we should aggregate the data. So we need this, I see.
I want to destroy and aggregate these directories in the future.

test/extensions/wasm/test_data
test/extensions/common/wasm/test_data
test/extensions/filters/http/wasm/test_data
test/extensions/filters/network/wasm/test_data
test/extensions/access_loggers/wasm/test_data

@Shikugawa
add
2c89e33 
Signed-off-by: shikugawa <Shikugawa@gmail.com>
@Shikugawa Shikugawa mentioned this pull request Apr 24, 2020
Merged
lizan and others added 9 commits April 24, 2020 21:53
@lizan
build: call bazel in bazel to build test_cpp.wasm
f8fa8b6 
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
@lizan
fix
54bafca 
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
@lizan
update build image
ebf0dac 
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
@lizan
fix test path
247cdca 
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
@lizan
fix
2212da4 
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
@Shikugawa
rust build
7ef5d60 
Signed-off-by: shikugawa <Shikugawa@gmail.com>
@Shikugawa
null plugin build
3790608 
Signed-off-by: shikugawa <Shikugawa@gmail.com>
@Shikugawa
delete wasm test data
587fc57 
Signed-off-by: shikugawa <Shikugawa@gmail.com>
@Shikugawa
build wasm from root
664f378 
Signed-off-by: shikugawa <Shikugawa@gmail.com>
@Shikugawa
Copy link
Member Author

Shikugawa commented May 8, 2020

Close this PR because I want to apply transition based wasm build in another.

@Shikugawa Shikugawa closed this May 8, 2020
@Shikugawa Shikugawa deleted the wasm-bazel-1 branch May 8, 2020 05:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jplevyak jplevyak Awaiting requested review from jplevyak jplevyak will be requested when the pull request is marked ready for review jplevyak is a code owner

@PiotrSikora PiotrSikora Awaiting requested review from PiotrSikora PiotrSikora will be requested when the pull request is marked ready for review PiotrSikora is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Shikugawa @PiotrSikora @lizan