This repository was archived by the owner on Dec 16, 2020. It is now read-only.
build: fix linking against wasm-c-api on macOS.#26
Merged
PiotrSikora merged 2 commits intoenvoyproxy:masterfrom May 31, 2019
Merged
build: fix linking against wasm-c-api on macOS.#26PiotrSikora merged 2 commits intoenvoyproxy:masterfrom
PiotrSikora merged 2 commits intoenvoyproxy:masterfrom
Conversation
While there, re-enable make/free accounting, since it was broken for the same reason (implementation was leaked into headers). Fixes envoyproxy#18. Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Contributor
Author
jplevyak
reviewed
May 30, 2019
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
jplevyak
approved these changes
May 31, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While there, re-enable make/free accounting, since it was broken
for the same reason (implementation was leaked into headers).
Fixes #18.
Signed-off-by: Piotr Sikora piotrsikora@google.com