Skip to content
This repository was archived by the owner on Dec 16, 2020. It is now read-only.
This repository was archived by the owner on Dec 16, 2020. It is now read-only.

Compile with protobuf full does not work with V8 #32

@bianpengyuan

Description

@bianpengyuan

I tried to recompile the example in example/wasm/ wasm module with intrinsics.proto and libprotobuf instead of libprotobuf_lite, but v8 failed to run it.

diff --git a/examples/wasm/Makefile b/examples/wasm/Makefile
index 9a71c6f23..650ce9393 100644
--- a/examples/wasm/Makefile
+++ b/examples/wasm/Makefile
@@ -1,3 +1,3 @@
 all: envoy_filter_http_wasm_example.wasm
 
-include ../../api/wasm/cpp/Makefile.base_lite
+include ../../api/wasm/cpp/Makefile.base
diff --git a/examples/wasm/envoy.yaml b/examples/wasm/envoy.yaml
index f89990a7f..61b4a2097 100644
--- a/examples/wasm/envoy.yaml
+++ b/examples/wasm/envoy.yaml
@@ -26,7 +26,7 @@ static_resources:
           - name: envoy.wasm
             config:
               vm_config:
-                vm: "envoy.wasm.vm.wavm"
+                vm: "envoy.wasm.vm.v8"
                 code:
                   filename: "/etc/envoy_filter_http_wasm_example.wasm"
                 allow_precompiled: true

Here is the error output:

[libprotobuf  google/protobuf/descriptor_database.cc:318] Invalid file descriptor data passed to EncodedDescriptorDatabase::Add().

We've seen this before when running wasm-sd module and we thought the problem might be from generated code there. But seems like it is more fundamental than that.

@PiotrSikora @jplevyak

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions