kotlin: add simple grpc echo server/client#473
Merged
buildbreaker merged 15 commits intomasterfrom Oct 8, 2019
Merged
Conversation
buildbreaker
commented
Oct 4, 2019
| shallow_since = "1561081499 -0700", | ||
| ) | ||
|
|
||
| # gRPC java for @rules_proto_grpc |
buildbreaker
commented
Oct 4, 2019
rebello95
reviewed
Oct 8, 2019
| load("//bazel:kotlin_test.bzl", "envoy_mobile_kt_test") | ||
|
|
||
| envoy_mobile_kt_test( | ||
| name = "darwin_grpc_codec_test", |
Contributor
There was a problem hiding this comment.
This should probably not say darwin since it's running on linux
Author
There was a problem hiding this comment.
oops -- I can make a change in another PR
rebello95
reviewed
Oct 8, 2019
| @@ -0,0 +1,18 @@ | |||
| syntax = "proto3"; | |||
|
|
|||
| package io.envoyproxy.envoymobile; | |||
Contributor
There was a problem hiding this comment.
This should match the folder path
rebello95
reviewed
Oct 8, 2019
|
|
||
| package io.envoyproxy.envoymobile; | ||
|
|
||
| message Request { |
rebello95
previously approved these changes
Oct 8, 2019
added 15 commits
October 8, 2019 13:31
Signed-off-by: Alan Chiu <achiu@lyft.com>
Signed-off-by: Alan Chiu <achiu@lyft.com>
Signed-off-by: Alan Chiu <achiu@lyft.com>
Signed-off-by: Alan Chiu <achiu@lyft.com>
Signed-off-by: Alan Chiu <achiu@lyft.com>
Signed-off-by: Alan Chiu <achiu@lyft.com>
Signed-off-by: Alan Chiu <achiu@lyft.com>
Signed-off-by: Alan Chiu <achiu@lyft.com>
8f09208 to
f3ae9fd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#489
Integrating https://github.com/rules-proto-grpc/rules_proto_grpc to unblock testing for our gRPC codec
Followed the instructions for integrating with java here:
https://github.com/rules-proto-grpc/rules_proto_grpc/tree/master/java
Signed-off-by: Alan Chiu achiu@lyft.com
Description: kotlin: Add simple grpc echo server/client
Risk Level: low
Testing: unit
Docs Changes: n/a
Release Notes: n/a
[Optional Fixes #Issue]
[Optional Deprecated:]