core: introduce interface for setting preferred network#442
Merged
Conversation
Signed-off-by: Mike Schore <mike.schore@gmail.com>
Signed-off-by: Mike Schore <mike.schore@gmail.com>
rebello95
reviewed
Sep 17, 2019
added 2 commits
September 18, 2019 09:59
Signed-off-by: Jose Nino <jnino@lyft.com>
rebello95
reviewed
Sep 20, 2019
|
|
||
| /** | ||
| * Update the network interface to the preferred network for opening new streams. | ||
| * Note that this state is shared by all engines. |
Contributor
There was a problem hiding this comment.
Is this permanent? Seems like ideally we'd be able to set this per-engine (especially since we don't expose a singleton on the platform layer).
Contributor
Author
There was a problem hiding this comment.
The presumption here is that the same networks/interfaces are available to any thread in the process. As long as that's true, there's no real inherent need for the state to be replicated.
I could see per-instance state being slightly more testable, maybe.
rebello95
reviewed
Sep 20, 2019
Signed-off-by: Mike Schore <mike.schore@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: This is to allow OS/platform reachability signals to be consumed by the Envoy library engine.
Co-authored-by: Jose Nino jnino@lyft.com
Signed-off-by: Mike Schore mike.schore@gmail.com