Skip to content

ios: implement gRPC & add tests#416

Merged
rebello95 merged 25 commits intomasterfrom
grpc-wip
Sep 12, 2019
Merged

ios: implement gRPC & add tests#416
rebello95 merged 25 commits intomasterfrom
grpc-wip

Conversation

@rebello95
Copy link
Copy Markdown
Contributor

@rebello95 rebello95 commented Sep 6, 2019 •
edited
Loading

Implements the gRPC protocol on top of the existing Envoy Mobile interfaces, allowing for easily sending gRPC requests over Envoy.

Note: The GRPCResponseHandler isn't kept in memory by the library (similarly to ResponseHandler) - only its closures are passed down to the core. Thus, no state is stored on the handler, and the necessary data is kept in memory by the closures capturing it.

Throughout the buffering function, we're currently copying some data by doing append calls. This may be optimized further in the future.

This PR also includes a set of tests for this new functionality.

Example of sending a gRPC request:

let handler = GRPCResponseHandler(queue: .main)
    .onHeaders { headers, grpcStatus, _ in
        print("gRPC status: \(grpcStatus), headers: \(headers)")
    }
    .onMessage { messageData, _ in
        print("Got message over gRPC: \(messageData)")
    }
    .onError { error in
        print("gRPC failed with error: \(error)")
    }

let requestBuilder = GRPCRequestBuilder(path: "/pb.api.v1.foo.Bar/Baz",
                                        authority: "api.foo.com")
let emitter = GRPCClient(httpClient: envoy).send(requestBuilder.build(), handler: handler)
emitter.sendMessage(someProtoMessage.serializedData())
...

Risk Level: Low (new feature)
Testing: Unit tests, tested locally

Signed-off-by: Michael Rebello me@michaelrebello.com

@rebello95
WIP: implement gRPC
417fc49 
Signed-off-by: Michael Rebello <me@michaelrebello.com>
Reflejo
Reflejo reviewed Sep 6, 2019
View reviewed changes
@rebello95
wip
d67a598 
Signed-off-by: Michael Rebello <me@michaelrebello.com>
@rebello95
Update swift_static_framework.bzl
de1b64f 
Signed-off-by: Michael Rebello <me@michaelrebello.com>
@rebello95
Update swift_static_framework.bzl
0af0efa 
Signed-off-by: Michael Rebello <me@michaelrebello.com>
@rebello95
updates
0cf784e 
Signed-off-by: Michael Rebello <me@michaelrebello.com>
@rebello95
Merge remote-tracking branch 'origin/master' into grpc-wip
4e2ec32 
Signed-off-by: Michael Rebello <me@michaelrebello.com>
@rebello95
tests
ff805f1 
Signed-off-by: Michael Rebello <me@michaelrebello.com>
@rebello95
linter
44391c2 
Signed-off-by: Michael Rebello <me@michaelrebello.com>
@rebello95 rebello95 changed the title WIP: implement gRPC ios: implement gRPC with tests Sep 10, 2019
@rebello95
private
5e0d414 
Signed-off-by: Michael Rebello <me@michaelrebello.com>
@rebello95
Merge remote-tracking branch 'origin/master' into grpc-wip
30f88e3 
Signed-off-by: Michael Rebello <me@michaelrebello.com>
@rebello95 rebello95 marked this pull request as ready for review September 10, 2019 23:43
@rebello95 rebello95 changed the title ios: implement gRPC with tests ios: implement gRPC & add tests Sep 10, 2019
buildbreaker
buildbreaker reviewed Sep 11, 2019
View reviewed changes
buildbreaker
buildbreaker reviewed Sep 11, 2019
View reviewed changes
buildbreaker
buildbreaker previously approved these changes Sep 11, 2019
View reviewed changes
Copy link
Copy Markdown

@buildbreaker buildbreaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that we're explicitly exposing some decorative objects for interacting with Envoy in a Grpc manner

@rebello95
CR
2b2aed6 
Signed-off-by: Michael Rebello <me@michaelrebello.com>
buildbreaker
buildbreaker previously approved these changes Sep 11, 2019
View reviewed changes
@rebello95
public init
e4b1371 
Signed-off-by: Michael Rebello <me@michaelrebello.com>
@rebello95
support zero-length messages
15ac58e 
Signed-off-by: Michael Rebello <me@michaelrebello.com>
goaway
goaway reviewed Sep 11, 2019
View reviewed changes
@rebello95
Merge remote-tracking branch 'origin/master' into grpc-wip
48da6af 
Signed-off-by: Michael Rebello <me@michaelrebello.com>
@rebello95
fix after rebase
9882acb 
Signed-off-by: Michael Rebello <me@michaelrebello.com>
@rebello95
s/client/httpClient
9e9a894 
Signed-off-by: Michael Rebello <me@michaelrebello.com>
@rebello95
add another test
25c053e 
Signed-off-by: Michael Rebello <me@michaelrebello.com>
goaway
goaway reviewed Sep 11, 2019
View reviewed changes
goaway
goaway reviewed Sep 11, 2019
View reviewed changes
goaway
goaway reviewed Sep 11, 2019
View reviewed changes
goaway
goaway reviewed Sep 11, 2019
View reviewed changes
@rebello95
CR feedback
c25ce85 
Signed-off-by: Michael Rebello <me@michaelrebello.com>
@rebello95
fixup
dea53ab 
Signed-off-by: Michael Rebello <me@michaelrebello.com>
buildbreaker
buildbreaker previously approved these changes Sep 11, 2019
View reviewed changes
@rebello95
fix crash
1557aa4 
Signed-off-by: Michael Rebello <me@michaelrebello.com>
@rebello95
reduce copying
d82feae 
Signed-off-by: Michael Rebello <me@michaelrebello.com>
@rebello95
apply endianness
0d27e4c 
Signed-off-by: Michael Rebello <me@michaelrebello.com>
@rebello95 rebello95 requested a review from goaway September 12, 2019 06:41
@rebello95
inline notes
4ffd436 
Signed-off-by: Michael Rebello <me@michaelrebello.com>
@rebello95
Copy link
Copy Markdown
Contributor Author

rebello95 commented Sep 12, 2019

Thanks for the review and offline discussions, @goaway! Ready for another look.

@rebello95
rerun ci
b2689bf 
Signed-off-by: Michael Rebello <me@michaelrebello.com>
@rebello95 rebello95 mentioned this pull request Sep 12, 2019
Closed
goaway
goaway reviewed Sep 12, 2019
View reviewed changes
@rebello95
CFSwapInt32BigToHost
597a67f 
Signed-off-by: Michael Rebello <me@michaelrebello.com>
goaway
goaway approved these changes Sep 12, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@goaway goaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, nice work!

@rebello95
Copy link
Copy Markdown
Contributor Author

rebello95 commented Sep 12, 2019

Thanks for the review @goaway!

@rebello95 rebello95 merged commit f77954e into master Sep 12, 2019
@rebello95 rebello95 deleted the grpc-wip branch September 12, 2019 22:15
@buildbreaker buildbreaker mentioned this pull request Oct 4, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goaway goaway goaway approved these changes

@junr03 junr03 Awaiting requested review from junr03

+2 more reviewers

@Reflejo Reflejo Reflejo left review comments

@buildbreaker buildbreaker buildbreaker left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rebello95 @Reflejo @goaway @buildbreaker