Skip to content

upstream: update envoy submodule to tip of master#388

Merged
junr03 merged 8 commits intomasterfrom
update-envoy
Sep 17, 2019
Merged

upstream: update envoy submodule to tip of master#388
junr03 merged 8 commits intomasterfrom
update-envoy

Conversation

@junr03
Copy link
Copy Markdown
Member

@junr03 junr03 commented Aug 27, 2019

Description: taking in the tip of master
Risk Level: low
Testing: CI and local for iOS

Jose Nino added 4 commits August 27, 2019 11:28
upstream: update envoy submodule to tip of master
2dc09f9 
Signed-off-by: Jose Nino <jnino@lyft.com>
update workspace
92c22bd 
Signed-off-by: Jose Nino <jnino@lyft.com>
update enableTimer expectation
3281343 
Signed-off-by: Jose Nino <jnino@lyft.com>
update time callback
b5cd1c4 
Signed-off-by: Jose Nino <jnino@lyft.com>
buildbreaker
buildbreaker previously approved these changes Aug 28, 2019
View reviewed changes
goaway
goaway previously approved these changes Aug 28, 2019
View reviewed changes
@junr03
Copy link
Copy Markdown
Member Author

junr03 commented Aug 28, 2019

The size of the perf size binary grew by 4% compared to master. I will need to investigate what happened.

@stale
Copy link
Copy Markdown

stale bot commented Sep 4, 2019

This pull request has been automatically marked as stale because it has not had activity in the last 7 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@stale stale bot added the stale label Sep 4, 2019
@junr03
Copy link
Copy Markdown
Member Author

junr03 commented Sep 5, 2019

will close for now until I have time to investigate the size differential

@junr03 junr03 closed this Sep 5, 2019
Jose Nino added 2 commits September 17, 2019 09:52
Merge branch 'master' into update-envoy
e87070b 
Signed-off-by: Jose Nino <jnino@lyft.com>
update
b56208e 
Signed-off-by: Jose Nino <jnino@lyft.com>
@junr03 junr03 reopened this Sep 17, 2019
@junr03 junr03 dismissed stale reviews from goaway and buildbreaker via b56208e September 17, 2019 16:53
@stale stale bot removed the stale label Sep 17, 2019
@junr03 junr03 mentioned this pull request Sep 17, 2019
Closed
@junr03
Copy link
Copy Markdown
Member Author

junr03 commented Sep 17, 2019

I am going to merge this regardless of size increase -- as we think this is acceptable for the 0.2 release. However, I have cut #447 to track.

rebello95
rebello95 previously approved these changes Sep 17, 2019
View reviewed changes
check format
3dcfc40 
Signed-off-by: Jose Nino <jnino@lyft.com>
@junr03
Copy link
Copy Markdown
Member Author

junr03 commented Sep 17, 2019

envoyproxy/envoy@d0e1db6 broke relative paths for the python format checker. However, we don't need to run the python format checker in this project.

test fixes
30bde2b 
Signed-off-by: Jose Nino <jnino@lyft.com>
@junr03 junr03 merged commit d647afe into master Sep 17, 2019
@junr03 junr03 deleted the update-envoy branch September 17, 2019 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goaway goaway goaway left review comments

+2 more reviewers

@rebello95 rebello95 rebello95 approved these changes

@buildbreaker buildbreaker buildbreaker approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@junr03 @goaway @rebello95 @buildbreaker