core/ios: convert EnvoyHTTPStream to a protocol & fix tests#382
Merged
core/ios: convert EnvoyHTTPStream to a protocol & fix tests#382
Conversation
Signed-off-by: Michael Rebello <me@michaelrebello.com>
Signed-off-by: Michael Rebello <me@michaelrebello.com>
Signed-off-by: Michael Rebello <me@michaelrebello.com>
goaway
reviewed
Aug 27, 2019
Contributor
|
Looks good, just a minor suggestion (and needs a merge/rebase). |
|
This pull request has been automatically marked as stale because it has not had activity in the last 7 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
Signed-off-by: Michael Rebello <me@michaelrebello.com>
Signed-off-by: Michael Rebello <me@michaelrebello.com>
Contributor
Author
|
Thanks for reviewing @goaway - ready for another look |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#381 surfaced an issue where extensions aren't allowed on Swift protocols that are visible to Objective-C. This meant that the Swift
Clientprotocol (conformed to by theEnvoySwift class) could not provide a default implementation of the non-streamingsendfunction, and the function had to be moved into the concreteEnvoyclass so that it could be visible from both Swift and Objective-C. This ended up breaking our Swift tests inClientTests.swift(as mentioned in that PR's description).In order to fix these tests, we need to convert
EnvoyHTTPStreaminto a protocol and use anEnvoyHTTPStreamImplconcrete type - similarly to how we do withEnvoyEngine/EnvoyEngineImpl.This PR updates the types accordingly, and fixes the tests. Also renames the tests to
EnvoyTestsrather thanClientTestssince this is testing the concrete type.Signed-off-by: Michael Rebello me@michaelrebello.com