Conversation
Per the discussion [here](#312 (comment)), updating the unary and streaming interfaces. Also moving the non-streaming convenience function into an extension on the protocol type so that it's available to all consumers. Lastly, added a test to validate the default behavior of this extension function. Signed-off-by: Michael Rebello <me@michaelrebello.com>
goaway
reviewed
Aug 20, 2019
| @discardableResult | ||
| public func send(_ request: Request, data: Data?, | ||
| trailers: [String: [String]] = [:], handler: ResponseHandler) | ||
| -> CancelableStream |
Contributor
There was a problem hiding this comment.
CancelableStream is very clever; I like this approach.
goaway
reviewed
Aug 20, 2019
goaway
reviewed
Aug 20, 2019
buildbreaker
approved these changes
Aug 20, 2019
buildbreaker
left a comment
There was a problem hiding this comment.
I don't have a suggestion but I do feel that it's a bit awkward that we return an Emitter in one case but we return a Stream in another
We can change it later but that's my only thought here. The general ideas and APIs are 💯
Contributor
Author
|
@buildbreaker thanks for the callout - we can do something like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per the discussion here, updating the unary and streaming interfaces.
CancelableStreamprotocol which includes a subset of functionality from theStreamEmitter, allowing consumers of the unary function to cancel requests without having the ability to send additional data into the streamSigned-off-by: Michael Rebello me@michaelrebello.com