kotlin: add conversion from Request to headers#296
Merged
buildbreaker merged 4 commits intomasterfrom Jul 24, 2019
Merged
Conversation
added 4 commits
July 23, 2019 17:36
rebello95
reviewed
Jul 24, 2019
| } | ||
|
|
||
| @Test | ||
| fun `options method is added to outbound request headers`() { |
Contributor
There was a problem hiding this comment.
Not sure these additional tests for each of the RequestMethod cases really provide much value, but no harm in keeping them
Author
There was a problem hiding this comment.
I accidentally messed up writing the mapping from POST to "POST"
I mean the code review would've caught that but a test allowed me to not embarrass myself
rebello95
approved these changes
Jul 24, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirrors: #288
Adds converters to go from Request to a set of headers that upstream Envoy understands.
This will be utilized by the request logic in the Envoy class.
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Description: kotlin: add conversion from Request to headers
Risk Level: low
Testing: unit
Docs Changes: n/a
Release Notes: n/a
[Optional Fixes #Issue]
[Optional Deprecated:]