swift: add library response interfaces#273
Merged
Conversation
This was referenced Jul 19, 2019
…esponse-interfaces Signed-off-by: Michael Rebello <mrebello@lyft.com>
…esponse-interfaces Signed-off-by: Michael Rebello <mrebello@lyft.com>
Signed-off-by: Michael Rebello <mrebello@lyft.com>
goaway
reviewed
Jul 22, 2019
Signed-off-by: Michael Rebello <mrebello@lyft.com>
Signed-off-by: Michael Rebello <mrebello@lyft.com>
goaway
reviewed
Jul 22, 2019
| /// | ||
| /// - throws: `Envoy.Error` when the stream is inactive or data can't be sent. | ||
| public func close() throws { | ||
| try self.close(trailers: [:]) |
Signed-off-by: Michael Rebello <mrebello@lyft.com>
goaway
approved these changes
Jul 22, 2019
Contributor
goaway
left a comment
There was a problem hiding this comment.
Nice work, this looks great.
Contributor
Author
|
Just to cross-reference, more discussions were had in this PR which were applied here too: #265 |
buildbreaker
approved these changes
Jul 22, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Swift interfaces for responses within Envoy. These should be at parity with the interfaces being added for Kotlin in #265.
Replaces #261.
Resolves #118.
Also resolves #247.
Signed-off-by: Michael Rebello mrebello@lyft.com