Allow library/common/jni/ to be built on non-Android platforms#2685
Closed
RyanTheOptimist wants to merge 2 commits intoenvoyproxy:mainfrom
Closed
Allow library/common/jni/ to be built on non-Android platforms#2685RyanTheOptimist wants to merge 2 commits intoenvoyproxy:mainfrom
RyanTheOptimist wants to merge 2 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Ryan Hamilton <rch@google.com>
efa572b to
77aea49
Compare
Contributor
Author
|
/assign @jpsim |
jpsim
reviewed
Dec 1, 2022
Comment on lines
-69
to
+70
| "-llog", | ||
| ] + select({ | ||
| "@envoy//bazel:dbg_build": ["-Wl,--build-id=sha1"], | ||
| "@envoy//bazel:android": ["-llog"], |
Contributor
There was a problem hiding this comment.
Is select mutually exclusive? I.e. should this be two selects?
Contributor
|
Sorry for the delay in reviewing this, I missed it while I was out. Would you be ok to close this and re-open in Envoy? |
Contributor
Author
Sure, no problem! (I forgot I had this PR open, too) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow library/common/jni/ to be built on non-Android platforms
Use bazel select to make a number of android-specific targets conditional on Android.
Risk Level: Low
Testing: N/A
Docs Changes: N/A
Release Notes: N/A