Merged
Conversation
Signed-off-by: JP Simard <jp@jpsim.com>
Signed-off-by: JP Simard <jp@jpsim.com>
Contributor
|
@Yannic I checked the error and it seems to be coming from https://github.com/google/xctestrunner/blob/master/simulator_control/simulator_util.py#L149 so I went ahead and ran on the MacOS 12 worker: Are you sure you installed Command_Line_Tools_for_Xcode_13.4.dmg ? According to https://stackoverflow.com/questions/29108172/how-do-i-fix-the-xcrun-unable-to-find-simctl-error that's how you fix that kind of error. The command succeeds in the local GH runner. |
Contributor
|
Thanks @lfpino! I need to read up on the command-line tools a bit. Will provide an update next week |
Contributor
Author
|
Probably just needs this command on the executors: |
* main: tools: fix source mapping (#2429) Update Envoy (#2427) tools: add arm64 debug run configuration (#2424) Revert "docs: use sphinx githubpages extension (#2418)" (#2425) Remove Tulsi configuration & docs (#2421) Fix isCleartextTrafficPermitted (#2420) Squelch two JNI build warnings (#2426) dns: allow using the `getaddrinfo`-based system DNS resolver (#2419) docs: use sphinx githubpages extension (#2418) Update Envoy (#2417) Remove rules_cc uses Bump Lyft Support Rotation (#2414) iOS: fix retain cycles in `EnvoyNetworkMonitor` (#2415) Update Envoy (#2413) engine: remove outdated comment about `registerFactories()` (#2412) api: make RequestTrailersBuilder and ResponseHeadersBuilder constructors public (#2410) Signed-off-by: JP Simard <jp@jpsim.com>
Contributor
Author
|
The EngFlow executors have been updated to have macOS 12 & Xcode 13.4 so this is now ready for review. |
keith
approved these changes
Jul 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the version of Xcode Envoy Mobile is compatible with to the latest stable version (sorta, 13.4.1 also exists but doesn't have relevant changes).
Risk Level: Low.
Testing: Local & CI.
Docs Changes: Done.
Release Notes: Done.
Fixes #2100
Signed-off-by: JP Simard jp@jpsim.com