Merged
Conversation
This upgrades `rules_foreign_cc` to a version including bazel-contrib/rules_foreign_cc#938, which fixes a build failure when the requested Apple SDK from `--xcode_version` does not match the system's default Xcode's SDKs. Example output: ``` rules_foreign_cc: Build failed! rules_foreign_cc: Keeping temp build directory and dependencies directory for debug. rules_foreign_cc: Please note that the directories inside a sandbox are still cleaned unless you specify --sandbox_debug Bazel command line flag. rules_foreign_cc: Printing build logs: _____ BEGIN BUILD LOGS _____ xcrun: error: SDK "macosx12.1" cannot be located xcrun: error: SDK "macosx12.1" cannot be located xcrun: error: unable to lookup item 'Path' in SDK 'macosx12.1' + XCODE_VERSION_OVERRIDE=13.2.1.13C100 + APPLE_SDK_VERSION_OVERRIDE=12.1 + APPLE_SDK_PLATFORM=MacOSX ``` This fixes a hermeticity problem in the build and is a prerequisite for upgradting the macOS RE cluster to macOS 12, which in turn is a requirement for upgrading to Xcode 13.4. Progress on envoyproxy#2100 Signed-off-by: Yannic Bonenberger <yannic@engflow.com>
Contributor
Author
jpsim
approved these changes
Jul 5, 2022
Contributor
jpsim
left a comment
There was a problem hiding this comment.
👍 I've actually seen this issue locally when DEVELOPER_DIR was set to a different Xcode than what's defined with xcode_version.
I'll keep an eye on bazel-contrib/rules_foreign_cc#938 and will update to point to the official repo when that's merged.
Contributor
|
This is great - thank you. I've definitely hit this error in the past. |
Contributor
|
If the upstream PR can't be merged for any reason, we may need to revert this if it prevents us from staying up to date with the official rules repo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This upgrades
rules_foreign_ccto a version includingbazel-contrib/rules_foreign_cc#938, which fixes
a build failure when the requested Apple SDK from
--xcode_versiondoesnot match the system's default Xcode's SDKs.
Example output:
This fixes a hermeticity problem in the build and is a prerequisite for
upgradting the macOS RE cluster to macOS 12, which in turn is a
requirement for upgrading to Xcode 13.4.
Progress on #2100