Cancel the scheduled onSendWindowAvailable callback when a stream is cancelled#2292
Merged
RyanTheOptimist merged 3 commits intoenvoyproxy:mainfrom May 19, 2022
Merged
Conversation
…cancelled. Fixes: envoyproxy#2213 Signed-off-by: Ryan Hamilton <rch@google.com>
alyssawilk
previously approved these changes
May 18, 2022
Contributor
alyssawilk
left a comment
There was a problem hiding this comment.
Nice!
For all I'm torn between praising you for finding this and kicking myself for not catching it in review :-P
Contributor
|
main merge though |
alyssawilk
approved these changes
May 18, 2022
goaway
approved these changes
May 19, 2022
jpsim
reviewed
May 19, 2022
|
|
||
| - iOS: change release artifacts to use xcframeworks (:issue:`#2216 <2216>`) | ||
| - iOS: fix CocoaPods releases (:issue:`#2215 <2215>`) | ||
| - Cronvy: Cancel the scheduled onSendWindowAvailable callback when a stream is cancelled (:issue:`#2213 <2213>`) |
Contributor
Author
There was a problem hiding this comment.
facepalm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cancel the scheduled onSendWindowAvailable callback when a stream is cancelled
Fixes: #2213
Signed-off-by: Ryan Hamilton rch@google.com
Risk Level: Low
Testing: New unit tests
Docs Changes: None
Release Notes: Updated