Merged
Conversation
There is a set of configurations that we can slow down on mobile from their defaults upstream because they aren't as relevant to mobile clients. This change updates our example configurations to use new values based on [this discussion](#113 (comment)). When we switch to typed configurations, these should also be set automatically for production clients: #169 Signed-off-by: Michael Rebello <mrebello@lyft.com>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a set of configurations that we can slow down on mobile from their defaults upstream because they aren't as relevant to mobile clients.
This change updates our example configurations to use new values based on this discussion.
When we switch to typed configurations, these should also be set automatically for production clients: #169
Risk Level: Low
Testing: CI and locally
Docs Changes: None
Release Notes: N/A